Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVP working dataconnect:sql:shell #7778

Merged
merged 12 commits into from
Oct 17, 2024
Merged

MVP working dataconnect:sql:shell #7778

merged 12 commits into from
Oct 17, 2024

Conversation

tammam-g
Copy link
Contributor

@tammam-g tammam-g commented Oct 1, 2024 •
edited
Loading

Description

Connect to your cloudsql instance directly from CLI using your IAM creds.

Scenarios Tested

Tested Select, Drop, exit, errors, multiline input (copy paste multiple lines doesn't work properly though).
Screenshot 2024-10-07 at 5 26 55 PM

Sample Commands

firebase dataconnect:sql:shell

@tammam-g tammam-g requested review from joehan and fredzqm October 7, 2024 21:20
@tammam-g tammam-g marked this pull request as ready for review October 7, 2024 21:20
fredzqm
fredzqm reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sweet!

I'd like @joehan to take a pass as well

src/commands/dataconnect-sql-shell.ts Outdated Show resolved Hide resolved
joehan
joehan reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style suggestions, but this is looking pretty good!

src/commands/dataconnect-sql-shell.ts Outdated Show resolved Hide resolved
src/commands/dataconnect-sql-shell.ts Outdated Show resolved Hide resolved
src/commands/dataconnect-sql-shell.ts Outdated Show resolved Hide resolved
src/commands/dataconnect-sql-shell.ts Outdated Show resolved Hide resolved
src/commands/dataconnect-sql-shell.ts Outdated Show resolved Hide resolved
src/commands/dataconnect-sql-shell.ts Show resolved Hide resolved
@tammam-g tammam-g requested a review from joehan October 15, 2024 20:44
fredzqm
fredzqm approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's wait for Joe to do one final pass~

joehan
joehan requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to not use chalk, but LGTM otherwise.

src/gcp/cloudsql/interactive.ts Outdated Show resolved Hide resolved
@tammam-g tammam-g requested a review from joehan October 17, 2024 20:47
joehan
joehan reviewed Oct 17, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tammam-g @joehan
Update CHANGELOG.md
9944b4b 
Co-authored-by: joehan <[email protected]>
@tammam-g tammam-g enabled auto-merge (squash) October 17, 2024 22:13
@tammam-g tammam-g merged commit 4d87465 into master Oct 17, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

@fredzqm fredzqm fredzqm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tammam-g @joehan @fredzqm